Skip to content

Correct nullability annotation for IDataRecord #44938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2020
Merged

Correct nullability annotation for IDataRecord #44938

merged 2 commits into from
Nov 21, 2020

Conversation

@roji
Copy link
Member

@roji roji commented Nov 19, 2020

Fixes #44886

@ghost
Copy link

ghost commented Nov 19, 2020

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #44886

Author: roji
Assignees: -
Labels:

area-System.Data
Milestone: -

This was referenced Nov 19, 2020
Closed
Closed
@stephentoub
Copy link
Member

stephentoub commented Nov 19, 2020 •
edited
Loading

FYI, lots of breaks, e.g.

error CS8767: Nullability of reference types in type of parameter 'buffer' of 'long DbDataRecord.GetBytes(int i, long dataIndex, byte[] buffer, int bufferIndex, int length)' doesn't match implicitly implemented member 'long IDataRecord.GetBytes(int i, long fieldOffset, byte[]? buffer, int bufferoffset, int length)' (possibly because of nullability attributes).

stephentoub
stephentoub approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@roji roji merged commit 2f8959a into dotnet:master Nov 21, 2020
@roji roji mentioned this pull request Dec 2, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

area-System.Data

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IDataRecord.GetBytes/GetChars should be annotated to allow a null buffer

3 participants

@roji @stephentoub @Dotnet-GitSync-Bot