-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Arm64] AdvSIMD LoadPairVector64 and LoadPairVector128 #45020
Closed
echesakov
wants to merge
18
commits into
dotnet:master
from
echesakov:Arm64-ASIMD-LoadPairVector64-LoadPairVector128
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cbd01ca
Support mulx returning ValueTuple
CarolEidt 7445ac0
Remove accidentially added build.out build-tests.out libs.out
echesakov a39417c
Add LoadPairVector64 and LoadPairVector128 in AdvSimd.cs AdvSimd.Plat…
echesakov 5c200a0
Add LoadPairScalarVector64 in AdvSimd.cs AdvSimd.PlatformNotSupported.cs
echesakov 41fda0d
Add LoadPairVector64NonTemporal and LoadPairVector128NonTemporal in A…
echesakov b1ba848
Add LoadPairScalarVector64NonTemporal in AdvSimd.cs AdvSimd.PlatformN…
echesakov c662e7f
Update System.Runtime.Intrinsics.cs
echesakov 3608e63
Add LoadPairVector64 and LoadPairVector128 in hwintrinsiclistarm64.h
echesakov 3f1f20a
Support LoadPairVector128/64 in Compiler::impHWIntrinsic in src/corec…
echesakov 8873f70
Exclude changes affecting current code generation of Bmi2.MultiplyNoF…
echesakov a69244e
Support multireg hardware intrinsics on Arm64 in src/coreclr/src/jit/…
echesakov 7b51ee7
Support LoadPairVector128/64 in Compiler::impSpecialIntrinsic in src/…
echesakov 9828c6e
Support LoadPairVector128/64 in CodeGen::genHWIntrinsic in src/corecl…
echesakov b20717f
Extend LinearScan::BuildHWIntrinsic to support intrinsics returning v…
echesakov e6cb0d3
Add LoadPairVectorTest.template
echesakov 4d808e3
Add LoadPairVector64 and LoadPairVector128 in GenerateTests.csx
echesakov 3b97de6
Add .Take() in src/tests/JIT/HardwareIntrinsics/Arm/Shared/Helpers.cs…
echesakov d5aba6d
Update src/tests/JIT/HardwareIntrinsics/Arm/AdvSimd.Arm64/*
echesakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarolEidt I think I need to implement a similar logic on Arm64 to avoid store-reload of returned SIMD values for
ldp
/ldnp
as in the following example:Is it correct understanding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe that's correct. However, this path is only for the case where you wind up with a
STORE_BLK
, as opposed to aSTORE_LCL_VAR
. If the lhs is a multi-reg lclVar, you should have the latter.