Convert several FCalls to QCalls, plus misc cleanup #45258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
This is converting the few methods both us have been staring at a lot in last few days, and also deletes the unused arguments. |
jkotas
commented
Nov 26, 2020
| [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.NonPublicConstructors)] | ||
| Type type) | ||
| { | ||
| if (type is null) |
There was a problem hiding this comment.
Undid the sharing here. There was more lines duplicated than shared.
stephentoub
reviewed
Nov 26, 2020
...clr/src/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 26, 2020
src/libraries/System.Private.CoreLib/src/System/Activator.RuntimeType.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 26, 2020
Comment on lines
143
to
151
| if (type is null) | ||
| { | ||
| throw new ArgumentNullException(nameof(type), SR.ArgumentNull_Type); | ||
| } | ||
|
|
||
| if (!(type is RuntimeType rt)) | ||
| { | ||
| throw new SerializationException(SR.Format(SR.Serialization_InvalidType, type)); | ||
| } |
stephentoub
approved these changes
Nov 26, 2020
…ilerServices/RuntimeHelpers.CoreCLR.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
…imeType.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.