[master] Update dependencies from dotnet/runtime #45387

dotnet-maestro · 2020-11-30T21:54:55Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: a67af1d4-463b-4caf-856e-08d895558180
Build: 20201214.10
Date Produced: 12/15/2020 8:14 AM
Commit: c64861b
Branch: refs/heads/master

Updates:
- runtime.native.System.IO.Ports: from 6.0.0-alpha.1.20602.4 to 6.0.0-alpha.1.20614.10
- Microsoft.NETCore.ILAsm: from 5.0.0-preview.8.20359.4 to 6.0.0-alpha.1.20614.10
- Microsoft.NETCore.DotNetHostPolicy: from 6.0.0-alpha.1.20602.4 to 6.0.0-alpha.1.20614.10
- Microsoft.NET.Sdk.IL: from 6.0.0-alpha.1.20602.4 to 6.0.0-alpha.1.20614.10
- Microsoft.NETCore.DotNetHost: from 6.0.0-alpha.1.20602.4 to 6.0.0-alpha.1.20614.10
- System.Runtime.CompilerServices.Unsafe: from 6.0.0-alpha.1.20602.4 to 6.0.0-alpha.1.20614.10
- System.Text.Json: from 6.0.0-alpha.1.20602.4 to 6.0.0-alpha.1.20614.10

…1130.7 runtime.native.System.IO.Ports , Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20580.7

Dotnet-GitSync-Bot · 2020-11-30T21:54:57Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

…1201.3 runtime.native.System.IO.Ports , Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20601.3

'JsonSerializerOptions.IgnoreNullValues' is obsolete: 'To ignore null values when serializing, set DefaultIgnoreCondition to JsonIgnoreCondition.WhenWritingNull.'

akoeplinger · 2020-12-02T00:54:42Z

Seems we're running into Classic PDB format is not supported on CoreCLR. error with the new ilasm.

Looks like this is because of 99bbb19 which added support for writing PDBs when /DEBUG is passed to ilasm, but the default seems to be /PDBFMT=CLASSIC which doesn't work on coreclr.

@noahfalk @BruceForstall @AaronRobinsonMSFT I'm not sure if we can easily detect coreclr in src/coreclr/src/.nuget/Microsoft.NET.Sdk.IL/targets/Microsoft.NET.Sdk.IL.targets so we can pass /PDBFMT=PORTABLE, any ideas?

BruceForstall · 2020-12-02T01:18:12Z

I don't know how those targets file work, esp. for Core vs. non-Core. Isn't the referenced Microsoft.NET.Sdk.IL.targets only for coreclr? In which case maybe anything passing -DEBUG should also pass /PDBFMT=PORTABLE?

@davidwrighton comments?

…1202.2 runtime.native.System.IO.Ports , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20602.2

akoeplinger · 2020-12-02T13:45:12Z

Actually, isn't the ilasm built from this repo always using coreclr (since the sources aren't shared back with netframework afaik), so maybe we should just default to portable PDB in ilasm?

BruceForstall · 2020-12-02T18:12:29Z

You could presumably use the dotnet/runtime ilasm to build code to be used for .NET Framework, but that seems unlikely. More likely, there was probably a desire not to change existing command-line behavior. I'm not sure what the correct default should be.

ViktorHofer · 2020-12-03T00:23:16Z

I think switching to portable as the default sounds reasonable but I'm not an expert in that area. cc @ericstj

akoeplinger · 2020-12-03T00:26:27Z

The netframework version of ilasm doesn't have the /PDBFMT option so there shouldn't be any compatibility issues.

If I understand @AaronRobinsonMSFT comment on #39436 (comment) correctly ~~it sounds like the intention was indeed to use Portable PDB as the default, it just didn't happen?~~ actually now that I read it again it seems keeping Classic as the default was intentional, however it feels kinda wrong to me if it doesn't work anyway.

ericstj · 2020-12-03T00:29:19Z

At least the ILSDK targets should be made to understand the same properties that CSC uses to set the PDB type. That'll resolve the warning/error. As far as defaults, that can be a different discussion.

akoeplinger · 2020-12-03T00:32:48Z

@ericstj I'm not sure it'd fix the build error since we seem to have some cases where we actually pass DebugType=Full otherwise we wouldn't pass /DEBUG to ikdasm:

runtime/src/coreclr/src/.nuget/Microsoft.NET.Sdk.IL/targets/Microsoft.NET.Sdk.IL.targets

Lines 131 to 133 in b9de3d0

    
           <_IlasmSwitches Condition="'$(DebugType)' == 'Full'">$(_IlasmSwitches) -DEBUG</_IlasmSwitches> 
        
           <_IlasmSwitches Condition="'$(DebugType)' == 'Impl'">$(_IlasmSwitches) -DEBUG=IMPL</_IlasmSwitches> 
        
           <_IlasmSwitches Condition="'$(DebugType)' == 'PdbOnly'">$(_IlasmSwitches) -DEBUG=OPT</_IlasmSwitches>

ericstj · 2020-12-03T02:23:13Z

Fix that too then :) Here:

runtime/src/libraries/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.ilproj

Line 12 in fde9281

<IlasmFlags>$(IlasmFlags) -DEBUG=$(DebugOptimization)</IlasmFlags>

…1203.3 runtime.native.System.IO.Ports , Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20603.3

…1203.13 runtime.native.System.IO.Ports , Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20603.13

…26e7a6

…1204.10 runtime.native.System.IO.Ports , Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20604.10

…1205.2 runtime.native.System.IO.Ports , Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20605.2

…1206.6 runtime.native.System.IO.Ports , Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20606.6

…1208.2 runtime.native.System.IO.Ports , Microsoft.NETCore.ILAsm , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20608.2

radical · 2020-12-08T16:36:57Z

Now ilasm failing with seg fault:

Target "CoreCompile: (TargetId:11731)" in file "/__w/1/s/.packages/microsoft.net.sdk.il/6.0.0-alpha.1.20608.2/targets/Microsoft.NET.Sdk.IL.targets" from project "/__w/1/s/src/libraries/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerSe
Building target "CoreCompile" completely.
Output file "/__w/1/s/artifacts/obj/System.Runtime.CompilerServices.Unsafe/netstandard2.0-Release/System.Runtime.CompilerServices.Unsafe.dll" does not exist.
Set Property: _OutputTypeArgument=-DLL
Set Property: _KeyFileArgument=-KEY="/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/6.0.0-beta.20601.2/tools/snk/MSFT.snk"
Set Property: _IlasmSwitches=-QUIET -NOLOGO
Set Property: _IlasmSwitches=-QUIET -NOLOGO -OPTIMIZE
Task "Exec" (TaskId:7532)
  Task Parameter:Command="/__w/1/s/.packages/runtime.linux-x64.microsoft.netcore.ilasm/6.0.0-alpha.1.20608.2/runtimes/linux-x64/native/ilasm" -QUIET -NOLOGO -OPTIMIZE -DLL  -DEBUG=OPT -PDBFMT=PORTABLE -INCLUDE="/__w/1/s/artifacts/obj/System.Runtime.Comp
  "/__w/1/s/.packages/runtime.linux-x64.microsoft.netcore.ilasm/6.0.0-alpha.1.20608.2/runtimes/linux-x64/native/ilasm" -QUIET -NOLOGO -OPTIMIZE -DLL  -DEBUG=OPT -PDBFMT=PORTABLE -INCLUDE="/__w/1/s/artifacts/obj/System.Runtime.CompilerServices.Unsafe/net
  Segmentation fault (core dumped) (TaskId:7532)
/__w/1/s/.packages/microsoft.net.sdk.il/6.0.0-alpha.1.20608.2/targets/Microsoft.NET.Sdk.IL.targets(138,5): error MSB3073: The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.netcore.ilasm/6.0.0-alpha.1.20608.2/runtimes/linux-x64/native/ilasm" -
  Output Property: _ILAsmExitCode=139 (TaskId:7532)
Done executing task "Exec" -- FAILED. (TaskId:7532)
Done building target "CoreCompile" in project "System.Runtime.CompilerServices.Unsafe.ilproj" -- FAILED.: (TargetId:11731)

https://dev.azure.com/dnceng/public/_build/results?buildId=912359&view=logs&jobId=108d2c4a-8a62-5a58-8dad-8e1042acc93c&j=108d2c4a-8a62-5a58-8dad-8e1042acc93c&t=568f884b-cc12-5fd3-e7fe-790b5ac403f4

…1209.2 runtime.native.System.IO.Ports , Microsoft.NETCore.ILAsm , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20609.2

…1209.15 runtime.native.System.IO.Ports , Microsoft.NETCore.ILAsm , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NET.Sdk.IL , Microsoft.NETCore.DotNetHost , System.Text.Json From Version 5.0.0-alpha.1.19563.3 -> To Version 6.0.0-alpha.1.20609.15

…26e7a6

See #45908

jkotas · 2020-12-15T17:50:03Z

Ugh, that is a lot of files that need this workaround. I doubt that this set is complete. I think we should get the proper fix in ilasm in place instead.

akoeplinger · 2020-12-15T17:53:29Z

@jkotas I did run every .il file in src/tests through ilasm manually and fixed all of the cases where it crashed so I'm reasonably sure it is the complete set.

jkotas · 2020-12-15T17:57:05Z

Still, I think it would be better to get the proper fix in ilasm instead of touching 400+ files.

jkotas · 2020-12-15T18:09:58Z

#46080 has the fix for the ilasm crash. Could you please revert the workaround and wait for it get merged?

.

ViktorHofer

Just to prevent the PR from being auto-merged accidentally.

This reverts commit 54eb3ee.

This reverts commit 2906310.

ViktorHofer · 2020-12-16T13:19:04Z

Failure is #11063.

dotnet-maestro bot and others added 2 commits December 1, 2020 13:17

Replace obsoleted json serializer option

cbb03a0

'JsonSerializerOptions.IgnoreNullValues' is obsolete: 'To ignore null values when serializing, set DefaultIgnoreCondition to JsonIgnoreCondition.WhenWritingNull.'

akoeplinger mentioned this pull request Dec 3, 2020

Hitting Classic PDB format is not supported on CoreCLR. while using 6.0 version of the ILASM package #45492

Closed

dotnet-maestro bot and others added 8 commits December 3, 2020 13:28

Use PDFMT=PORTABLE option for ilproj

f51c831

Merge branch 'master' into darc-master-8672eaad-b7a4-4bb1-8166-9393d9…

adb6dfe

…26e7a6

runfoapp bot mentioned this pull request Dec 8, 2020

Builds legs getting abandoned due to agent notification issues #35223

Closed

dotnet-maestro bot added 2 commits December 9, 2020 13:32

akoeplinger mentioned this pull request Dec 10, 2020

ilasm hitting segmentation fault when emitting portable PDBs #45908

Closed

jkotas added 2 commits December 10, 2020 19:09

Merge branch 'master' into darc-master-8672eaad-b7a4-4bb1-8166-9393d9…

a8acf88

…26e7a6

Add workaround for #45908

2906310

akoeplinger added 3 commits December 15, 2020 00:31

Merge branch 'master' into darc-master-8672eaad-b7a4-4bb1-8166-9393d9…

ad08650

…26e7a6

Update versions

15865c6

Remove PDBFMT option

353147f

akoeplinger previously approved these changes Dec 15, 2020

View reviewed changes

Apply ilasm .locals workaround for more files

54eb3ee

See #45908

ViktorHofer requested review from briansull and jkotas December 15, 2020 16:56

ViktorHofer requested changes Dec 15, 2020

View reviewed changes

This was referenced Dec 15, 2020

OSX deprovision jaredpar/runfo#41

Closed

Inability to unzip assets during build on Unix x64 #32805

Closed

OSX machines are de-provisioned during CI / PR runs leading to failures #34472

Closed

akoeplinger added 3 commits December 16, 2020 01:09

Revert "Apply ilasm .locals workaround for more files"

472d3fd

This reverts commit 54eb3ee.

Revert "Add workaround for #45908"

a148ac2

This reverts commit 2906310.

Update versions

22ba741

akoeplinger requested a review from ViktorHofer December 16, 2020 00:56

akoeplinger approved these changes Dec 16, 2020

View reviewed changes

jkotas approved these changes Dec 16, 2020

View reviewed changes

ViktorHofer approved these changes Dec 16, 2020

View reviewed changes

akoeplinger mentioned this pull request Dec 16, 2020

Malformed PDB file for a few runtime tests on Mono AOT after ilasm bump #46124

Closed

Disable tests that fail on Mono due to #46124

75c21c3

ViktorHofer merged commit 44e6223 into master Dec 16, 2020

ViktorHofer deleted the darc-master-8672eaad-b7a4-4bb1-8166-9393d926e7a6 branch December 16, 2020 13:19

ghost locked as resolved and limited conversation to collaborators Jan 15, 2021

danmoseley added the area-codeflow for labeling automated codeflow label Jul 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[master] Update dependencies from dotnet/runtime #45387

[master] Update dependencies from dotnet/runtime #45387

dotnet-maestro bot commented Nov 30, 2020 •

edited

Loading

Dotnet-GitSync-Bot commented Nov 30, 2020

akoeplinger commented Dec 2, 2020

BruceForstall commented Dec 2, 2020

akoeplinger commented Dec 2, 2020 •

edited

Loading

BruceForstall commented Dec 2, 2020

ViktorHofer commented Dec 3, 2020

akoeplinger commented Dec 3, 2020 •

edited

Loading

ericstj commented Dec 3, 2020

akoeplinger commented Dec 3, 2020 •

edited

Loading

ericstj commented Dec 3, 2020 •

edited

Loading

radical commented Dec 8, 2020 •

edited

Loading

jkotas commented Dec 15, 2020

akoeplinger commented Dec 15, 2020 •

edited

Loading

jkotas commented Dec 15, 2020

jkotas commented Dec 15, 2020

ViktorHofer left a comment

ViktorHofer commented Dec 16, 2020

[master] Update dependencies from dotnet/runtime #45387

[master] Update dependencies from dotnet/runtime #45387

Conversation

dotnet-maestro bot commented Nov 30, 2020 • edited Loading

From https://github.com/dotnet/runtime

Dotnet-GitSync-Bot commented Nov 30, 2020

akoeplinger commented Dec 2, 2020

BruceForstall commented Dec 2, 2020

akoeplinger commented Dec 2, 2020 • edited Loading

BruceForstall commented Dec 2, 2020

ViktorHofer commented Dec 3, 2020

akoeplinger commented Dec 3, 2020 • edited Loading

ericstj commented Dec 3, 2020

akoeplinger commented Dec 3, 2020 • edited Loading

ericstj commented Dec 3, 2020 • edited Loading

radical commented Dec 8, 2020 • edited Loading

jkotas commented Dec 15, 2020

akoeplinger commented Dec 15, 2020 • edited Loading

jkotas commented Dec 15, 2020

jkotas commented Dec 15, 2020

ViktorHofer left a comment

Choose a reason for hiding this comment

ViktorHofer commented Dec 16, 2020

dotnet-maestro bot commented Nov 30, 2020 •

edited

Loading

akoeplinger commented Dec 2, 2020 •

edited

Loading

akoeplinger commented Dec 3, 2020 •

edited

Loading

akoeplinger commented Dec 3, 2020 •

edited

Loading

ericstj commented Dec 3, 2020 •

edited

Loading

radical commented Dec 8, 2020 •

edited

Loading

akoeplinger commented Dec 15, 2020 •

edited

Loading