Ensure XslCompiledTransform works with TrimMode=link #45522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve ILLinker warnings in Xml.Xsl in order to make a basic Xslt scenario work. Fix dotnet#45393
|
mono windows x64 Debug failure is #45524 |
eerhardt
commented
Dec 3, 2020
| public static readonly MethodInfo XPPrecMergeNext = GetMethod(typeof(XPathPrecedingMergeIterator), "MoveNext"); | ||
| public static readonly MethodInfo AncCreate = typeof(AncestorIterator).GetMethod("Create")!; | ||
| public static readonly MethodInfo AncNext = typeof(AncestorIterator).GetMethod("MoveNext")!; | ||
| public static readonly MethodInfo AncCurrent = typeof(AncestorIterator).GetMethod("get_Current")!; |
There was a problem hiding this comment.
Note here I needed to add a new field Current for each Iterator type, so we could safely call get_Current without the linker trimming it away.
buyaa-n
reviewed
Dec 7, 2020
src/libraries/System.Private.Xml/tests/TrimmingTests/XslCompiledTransformTests.cs
Show resolved
Hide resolved
buyaa-n
reviewed
Dec 7, 2020
src/libraries/System.Private.Xml/tests/TrimmingTests/XslCompiledTransformTests.cs
Show resolved
Hide resolved
buyaa-n
approved these changes
Dec 7, 2020
krwq
approved these changes
Dec 8, 2020
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The only outerloop failures are in RegularExpressions.Tests. Merging. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve ILLinker warnings in Xml.Xsl in order to make a basic Xslt scenario work.
Fix #45393