Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] use Timer in MemoryCache #45842

Closed
wants to merge 8 commits into from
Closed

[Proposal] use Timer in MemoryCache #45842

wants to merge 8 commits into from

Commits on Dec 4, 2020

  1. don't get current time and check if scan for expired items should be … 

    …performed, use Timer instead
    @adamsitnik
    adamsitnik committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    dd6f6d3 View commit details
    Browse the repository at this point in the history

  2. remove duplicated code from tests

    @adamsitnik
    adamsitnik committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    c62b676 View commit details
    Browse the repository at this point in the history

  3. update tests: background activity is not required anymore

    @adamsitnik
    adamsitnik committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    1ca3e9a View commit details
    Browse the repository at this point in the history

  4. update tests: don't use the default expirationScanFrequency as these … 

    …two tests would need to wait for a minute to get result (CI would not like it)
    @adamsitnik
    adamsitnik committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    e498ae8 View commit details
    Browse the repository at this point in the history

  5. introduce CanExpire flag

    @adamsitnik
    adamsitnik committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    1ca7ab4 View commit details
    Browse the repository at this point in the history

  6. don't ask for current time if the entry that has been found can not b… 

    …e expired (TechEmpower case)
    @adamsitnik
    adamsitnik committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    38cff0e View commit details
    Browse the repository at this point in the history

  7. based on profiling apply or revert some micro optimizations

    @adamsitnik
    adamsitnik committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    d2397e1 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Merge remote-tracking branch 'upstream/master' into memoryCacheTimer 

    # Conflicts:
#	src/libraries/Microsoft.Extensions.Caching.Memory/src/CacheEntry.cs
    @adamsitnik
    adamsitnik committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    14b3513 View commit details
    Browse the repository at this point in the history