Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding null check on provider registration #46002

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

ovebastiansen
Copy link
Contributor

throwing argumentnull exception if the provider parameter is null. If the provider is null this can cause problems later in the chain

fix #45599

@ghost
Copy link

ghost commented Dec 12, 2020

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

throwing argumentnull exception if the provider parameter is null. If the provider is null this can cause problems later in the chain

fix #45599

Author: ovebastiansen
Assignees: -
Labels:

area-Extensions-Logging

Milestone: -

Copy link
Member

@maryamariyan maryamariyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryamariyan maryamariyan requested a review from safern December 15, 2020 16:14
@safern safern added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Dec 15, 2020
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Dec 15, 2020
@maryamariyan maryamariyan merged commit 1cdafd2 into dotnet:master Dec 15, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2021
@ericstj ericstj added this to the 6.0.0 milestone Sep 29, 2021
@maryamariyan maryamariyan removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing argument validation on 'LoggerFactory.AddProvider'
5 participants