-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove checkout bundle and job to improve reliability #46107
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
6406f9e
to
9b7d4fd
Compare
9b7d4fd
to
bbf318f
Compare
Tagging subscribers to this area: @ViktorHofer Issue DetailsTest if removing checkout bundle works and checks out the same commit and merges against the same commit in the target branch for the PR across all the legs.
|
b265b2d
to
f5b1fd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to finally see this workaround go, thanks Santi!
f5b1fd8
to
d90c836
Compare
Hello @safern! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
It seems like the azure devops bug where legs that started at a different time and a commit was introduced into the branch or target branch in between those legs, it would merge/checkout against a newer commit is fixed.
I did a test by:
As part of the surge we saw that this will help our reliability as sometimes we hit issues with the checkout bundle when downloading or uploading.
Also, the job was renamed to evaluate paths, and this will only run for pipelines that need it. At the moment only
runtime
andruntime-staging
use the evaluate paths feature.Test official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=923883&view=results
Test CI build: https://dev.azure.com/dnceng/public/_build/results?buildId=924110&view=results