Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkout bundle and job to improve reliability #46107

Merged
merged 8 commits into from
Dec 17, 2020
Merged

Conversation

safern
Copy link
Member

@safern safern commented Dec 16, 2020

It seems like the azure devops bug where legs that started at a different time and a commit was introduced into the branch or target branch in between those legs, it would merge/checkout against a newer commit is fixed.

I did a test by:

  1. Waiting for some legs to start and then pushing a commit to my branch (where I queued a manual build), then waited for other legs to start, they checked out the same commit (the one that was used to queue the build).
  2. Waited for some PR legs to start, then once those legs finished the checkout, I pushed a commit (doc change) to the master branch, and waited for other legs (test legs, build legs) that didn't start immediatly, to start. Once they started, they merged my PR branch against the same commit (the commit that the HEAD pointed to in the target branch when I opened the PR).

As part of the surge we saw that this will help our reliability as sometimes we hit issues with the checkout bundle when downloading or uploading.

Also, the job was renamed to evaluate paths, and this will only run for pipelines that need it. At the moment only runtime and runtime-staging use the evaluate paths feature.

Test official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=923883&view=results
Test CI build: https://dev.azure.com/dnceng/public/_build/results?buildId=924110&view=results

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@safern safern requested a review from a team December 16, 2020 20:05
@ghost
Copy link

ghost commented Dec 16, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Test if removing checkout bundle works and checks out the same commit and merges against the same commit in the target branch for the PR across all the legs.

Author: safern
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@safern safern marked this pull request as ready for review December 16, 2020 20:08
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to finally see this workaround go, thanks Santi!

@ghost
Copy link

ghost commented Dec 17, 2020

Hello @safern!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@safern safern merged commit f8a83c8 into master Dec 17, 2020
@safern safern deleted the RemoveCheckoutJob branch December 17, 2020 01:08
@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants