Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable static graph restore binlog generation #46270

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Dec 20, 2020

Static graph restore runs out-of-proc outside of msbuild.exe. To be able to diagnose project evaluation issues during restore, setting the switch to tell Arcade to set an env var which tells NuGet's out-of-proc static graph console to generate a binlog. I tested this locally and couldn't notice a measurable perf impact.

In addition, setting the var to a different value in tasks.proj which runs in an extra restore invocation to avoid that binlog to be overwritten by the restore invocation that follows afterwards.

@ViktorHofer ViktorHofer requested review from Anipik and safern December 20, 2020 16:05
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Dec 20, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Static graph restore runs out-of-proc outside of msbuild.exe. To be able to diagnose project evaluation issues during restore, setting the switch to tell Arcade to set an env var which tells NuGet's out-of-proc static graph console to generate a binlog. I tested this locally and couldn't notice a measurable perf impact.

In addition, setting the var to a different value in tasks.proj which runs in an extra restore invocation to avoid that binlog to be overwritten by the restore invocation that follows afterwards.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure

Milestone: -

@ViktorHofer ViktorHofer merged commit b783c5b into dotnet:master Dec 21, 2020
@ViktorHofer ViktorHofer deleted the BinLogRestore branch December 21, 2020 21:53
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants