Consolidate packaging properties #46331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Anipik
reviewed
Dec 22, 2020
Anipik
reviewed
Dec 22, 2020
Anipik
approved these changes
Dec 22, 2020
Anipik
reviewed
Dec 22, 2020
ViktorHofer
force-pushed
the
ConsolidatePkgprops
branch
from
6b1a2d2 to
8c17d70
Compare
ViktorHofer
removed request for
vargaz,
marek-safar,
steveisok,
EgorBo and
akoeplinger
Anipik
approved these changes
Dec 22, 2020
safern
reviewed
Dec 22, 2020
safern
reviewed
Dec 22, 2020
safern
reviewed
Dec 22, 2020
The versions.txt file was added to packages to know which SHA a package was built against. As the nuspec now contains the SHA, the versions file isn't necessary anymore.
|
Tagging subscribers to this area: @ViktorHofer Issue DetailsThe initial sweep of consolidating duplicated packaging properties. There is room for even more cleanup but that involves a bit more work which I will do in another PR.
|
|
Hello @ViktorHofer! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial sweep of consolidating duplicated packaging properties. There is room for even more cleanup but that involves a bit more work which I will do in another PR.