Fix macOS arm64 signature corruption at install #46452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `install(TARGET...)` for copying built binaries into the artifacts/bin/ results in cmake calling install_name_tool on the binary to set its id, which invalidates the code signature on macOS arm64. We were using `install(TARGET...)` only in the installer, libraries and coreclr use `install(PROGRAMS...)`. This change fixes the problem by replacing the `install(TARGET...)` by `install(PROGRAMS...)`. Even though the `install(TARGET...)` is the intended way to install executables produced by the build in cmake, it is meant for installing the binaries to their final location (like /usr/local/bin etc). But we don't use install in this way, we use it to copy the result into our `artifacts/bin/...` subfolder where the path doesn't match the final binary location in any way. So the extra massaging that cmake does for `install(TARGET...` is useless for our purposes anyways.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
sdmaclea
approved these changes
Dec 29, 2020
|
/cc @jkoritzinsky |
|
The Windows export libraries are missing with this approach. |
Hmm, too bad. Let's go your way then but make it more localized. I'll comment on your PR and close this one. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
install(TARGET...)for copying built binaries into the artifacts/bin/results in cmake calling install_name_tool on the binary to set its id, which
invalidates the code signature on macOS arm64.
We were using
install(TARGET...)only in the installer, libraries and coreclruse
install(PROGRAMS...).This change fixes the problem by replacing the
install(TARGET...)byinstall(PROGRAMS...). Even though theinstall(TARGET...)is the intendedway to install executables produced by the build in cmake, it is meant for
installing the binaries to their final location (like /usr/local/bin etc).
But we don't use install in this way, we use it to copy the result into our
artifacts/bin/...subfolder where the path doesn't match the final binarylocation in any way. So the extra massaging that cmake does for
install(TARGET...is useless for our purposes anyways.
Close #46369