Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R2RDump improvements #46833

Merged
merged 2 commits into from
Jan 12, 2021
Merged

R2RDump improvements #46833

merged 2 commits into from
Jan 12, 2021

Commits on Jan 11, 2021

  1. Improve R2RDump error message when an assembly is not R2R 

    * Fix `TryLocateNativeReadyToRunHeader` to swallow `BadImageFormatException` and return true / false whether the image has a native R2R header (for composite images).
* Running R2RDump on IL assemblies with no R2R now emits an error message that the assembly is not R2R instead of an unhelpful error about some RVA offset conversion failing.
    @nattress
    nattress committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    0026a3d View commit details
    Browse the repository at this point in the history

  2. [R2RDump] Fix signature parsing when module override token present 

    * Fix handling of module override token in signature parser. When the override is present, a new SignatureDecoder is created and used as the decoder for the final signature with the fixup kind (and module override flag which is stored in the upper bit of the fixup kind byte) already parsed. This causes the remainder of the signature to be parsed as a full R2R signature which is now missing the fixup type.
* Instead of creating a new decoder when a module override is present, set up the initial decoder's metadata reader in the constructor by detecting the module override up front.
    @nattress
    nattress committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    9895b78 View commit details
    Browse the repository at this point in the history