Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small PoliCheck fix #46876

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Small PoliCheck fix #46876

merged 1 commit into from
Jan 13, 2021

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jan 12, 2021

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Jan 12, 2021

Hello @hoyosjs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes, a condition that will be fulfilled in about 6 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@lambdageek
Copy link
Member

@hoyosjs please don't auto-merge PRs that will be mirrored to mono/mono. If the sync'd PR fails CI for some reason, we don't want to get into a state where one PR is merged and the other isn't.

@ghost
Copy link

ghost commented Jan 12, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: hoyosjs
Assignees: -
Labels:

area-VM-meta-mono

Milestone: -

@hoyosjs
Copy link
Member Author

hoyosjs commented Jan 13, 2021

@lambdageek I was going to merge this, but I noticed the build on mono/mono has an issue. Is is safe to merge in those cases ? The red on this side is a known issue in the infrastructure.

@akoeplinger
Copy link
Member

Yes it is an unrelated issue as well, I merged the Mono PR.

@akoeplinger akoeplinger merged commit 3b5e19c into master Jan 13, 2021
@akoeplinger akoeplinger deleted the juhoyosa/policheck-rt-1 branch January 14, 2021 17:18
@ghost ghost locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants