Do a JIT rolling build if the JIT-EE GUID changes #46963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, any JIT-EE GUID change would be accompanied by a change in the JIT source code, so a JIT build would be kicked off. But in some cases, such as a change in the SuperPMI data format to cause an incompatible format, with a manual change of the GUID to compensate, should also kick off a JIT build so asmdiff baselines have a JIT with an appropriate GUID.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
kunalspathak
approved these changes
Jan 14, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, any JIT-EE GUID change would be accompanied by
a change in the JIT source code, so a JIT build would be
kicked off. But in some cases, such as a change in the
SuperPMI data format to cause an incompatible format, with
a manual change of the GUID to compensate, should also
kick off a JIT build so asmdiff baselines have a JIT
with an appropriate GUID.