-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify obsoletion impact of 32-bit Process properties #47137
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @eiriktsarpalis Issue Details
Addresses #46901
|
@jeffhandley we have 114 obsoletion attributes in this repo that link to https://go.microsoft.com/fwlink/?linkid=14202 which is of limited if any relevance to .NET Core. (Same for its sibling topics). Eg it recommends appname.exe.config. I wonder whether we should either remove the links, or generalize the topics. The details of what is obsoleted and why are linked to from there but (a) it doesn't include newer obsoletions and (b) seems to add nothing over the attributes. Just mentioning in case this connects with the other obsoletion work you think about. |
src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs
Outdated
Show resolved
Hide resolved
Hello @danmosemsft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
I thought github's own automerge feature was enabled on this repo now, but I don't see it above.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @danmosemsft!
Addresses #46901