Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Add invocation to NuGet authentication scripts for internal feeds #47210

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jan 20, 2021

Needed to be able to authenticate internal feeds.

@ghost
Copy link

ghost commented Jan 20, 2021

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Needed to be able to authenticate internal feeds.

Author: hoyosjs
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@hoyosjs hoyosjs force-pushed the juhoyosa/setup-nugetfeeds-50 branch from c8a0b32 to 2077456 Compare January 20, 2021 05:51
@mmitche
Copy link
Member

mmitche commented Jan 20, 2021

Did this get tested on the internal PR? I normally would just plop this change on top of that

@hoyosjs hoyosjs added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 20, 2021
@hoyosjs
Copy link
Member Author

hoyosjs commented Jan 20, 2021

I had a test PR with a build. This is apparently not enough (it is for the coreclr, mono, and libraries, but not for the installer)

@hoyosjs hoyosjs removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 21, 2021
@hoyosjs
Copy link
Member Author

hoyosjs commented Jan 21, 2021

@hoyosjs hoyosjs merged commit e17680b into dotnet:release/5.0 Jan 21, 2021
@hoyosjs hoyosjs deleted the juhoyosa/setup-nugetfeeds-50 branch January 21, 2021 05:02
- ${{ each variable in parameters.variables }}:
- ${{ variable }}

steps:
- template: /eng/pipelines/common/clone-checkout-bundle-step.yml

- ${{ if ne(variables['System.TeamProject'], 'public') }}:
- ${{ if ne(parameters.osGroup, 'Windows_NT') }}:
- task: Bash@3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have done this with nuget authenticate plugin?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so at one point, but Matt recommended for this one (for cross org packages I believe).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just curious as we already use NuGet authenticate for cross org restoring for the icb merge restore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmitche Any reason to prefer one over the other?

@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants