-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/5.0] Add invocation to NuGet authentication scripts for internal feeds #47210
[release/5.0] Add invocation to NuGet authentication scripts for internal feeds #47210
Conversation
Tagging subscribers to this area: @ViktorHofer Issue DetailsNeeded to be able to authenticate internal feeds.
|
c8a0b32
to
2077456
Compare
2077456
to
f52ba06
Compare
Did this get tested on the internal PR? I normally would just plop this change on top of that |
I had a test PR with a build. This is apparently not enough (it is for the coreclr, mono, and libraries, but not for the installer) |
- ${{ each variable in parameters.variables }}: | ||
- ${{ variable }} | ||
|
||
steps: | ||
- template: /eng/pipelines/common/clone-checkout-bundle-step.yml | ||
|
||
- ${{ if ne(variables['System.TeamProject'], 'public') }}: | ||
- ${{ if ne(parameters.osGroup, 'Windows_NT') }}: | ||
- task: Bash@3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have done this with nuget authenticate plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so at one point, but Matt recommended for this one (for cross org packages I believe).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, just curious as we already use NuGet authenticate for cross org restoring for the icb merge restore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmitche Any reason to prefer one over the other?
Needed to be able to authenticate internal feeds.