Re-enable RunThreadLocalTest8_Values on Mono #47277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is possibly fixed by dotnet#44124 Since that PR mono will throw a ThreadStartException instead of an ExecutionEngineException if thread creation fails. The threadpool already catches ThreadStartException and can deal with thread creation failure. Related to dotnet#43981
stephentoub
approved these changes
Jan 21, 2021
akoeplinger
added a commit
that referenced
this pull request
Jan 22, 2021
This reverts commit f3cd4c6.
stephentoub
pushed a commit
that referenced
this pull request
Jan 22, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is possibly fixed by #44124
Since that PR mono will throw a
ThreadStartExceptioninstead of anExecutionEngineExceptionif thread creation fails. The threadpool already catchesThreadStartExceptionand can deal with thread creation failure.Related to #43981