-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Use socketpair to implement Process.Start redirection" #47461
Revert "Use socketpair to implement Process.Start redirection" #47461
Conversation
Tagging subscribers to this area: @eiriktsarpalis Issue DetailsReverts #34861 to address the regression reported in #46469. The goal is to backport the revert to cc @jeffhandley.
|
src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs
Show resolved
Hide resolved
2858601
to
e43ad7b
Compare
src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 Thanks.
…adTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
/backport to release/5.0 |
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/521211331 |
@eiriktsarpalis backporting to release/5.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Revert #34861
error: sha1 information is lacking or useless (src/libraries/Native/Unix/System.Native/pal_process.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Revert #34861
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
😢 |
…t#47461) * Revert dotnet#34861 * reinstate removed test * Update src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
… (#47644) * Revert "Use socketpair to implement Process.Start redirection" (#47461) * Revert #34861 * reinstate removed test * Update src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> * Add test validating against regression in #46469 (#47643) * Add test validating against regression in #46469 * fix test bug Co-authored-by: Stephen Toub <stoub@microsoft.com>
Is it included in 5.0.3? |
If all goes to schedule, 5.0.4 would be March patch Tuesday. |
Reverts #34861 to address the regression reported in #46469. The goal is to backport the revert to
release-5.0
and consider a different approach for 6 (e.g. the changes in #44647).cc @jeffhandley.