Add NotNullWhen(true) on Directory/File.Exists #47579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
stephentoub
reviewed
Jan 28, 2021
stephentoub
reviewed
Jan 28, 2021
stephentoub
approved these changes
Jan 28, 2021
Member
huoyaoyuan
force-pushed
the
directory-file-exists
branch
from
34c66e6 to
aef3041
Compare
Member
|
APICompat doesn't have a way to check nullable annotations yet, however we do plan on fixing this for the 6.0.0 release. Attribute differences should be flagged by APICompat just fine. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47573 .
Note: there were already annotations on ref of Directory and impl on File. Doesn't ApiCompact check this?