Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect offset in Socket.ReceiveMessageFrom(saea) on Windows #47642

Merged

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Jan 29, 2021

Fixes #47637, and also adds an equivalent test for ReceiveFrom as an extra.

/cc @geoffkizer @wfurt

@ghost
Copy link

ghost commented Jan 29, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #47637, and also adds an equivalent test for ReceiveFrom as an extra.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

@antonfirsov

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

# Conflicts:
#	src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveMessageFrom.cs
@antonfirsov
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov merged commit f47c1b5 into dotnet:master Feb 2, 2021
@geoffkizer
Copy link
Contributor

Wow, ugly. Thanks for finding and fixing.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket.ReceiveMessageFrom(saea) does not respect buffer offset on Windows
4 participants