Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement APM UDP Socket methods on top of task variants and consolidate related tests #47781

Merged
merged 25 commits into from
Feb 9, 2021
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
56cd081
cherry pick testfix
antonfirsov Jan 28, 2021
91834bc
SendTo + DELETEME notes
antonfirsov Jan 29, 2021
68aca2a
WIP
antonfirsov Jan 29, 2021
7d5278e
ReceiveFrom
antonfirsov Feb 1, 2021
3d3e762
ReceiveMessageFrom
antonfirsov Feb 1, 2021
98e53c9
WIP: consolidate ReceiveFrom argument validation tests
antonfirsov Feb 1, 2021
5702da3
BeginReceiveFrom_RemoteEpIsReturnedWhenCompletedSynchronously
antonfirsov Feb 1, 2021
0e8726f
WIP: consolidate ReceiveMessageFrom argument validation tests
antonfirsov Feb 1, 2021
d6fdd9b
consolidate ArgumentException-s
antonfirsov Feb 1, 2021
5a5fbba
Workaround for #47714
antonfirsov Feb 1, 2021
b6a417a
Merge branch 'master' into sockets/udp-UseTasks
antonfirsov Feb 2, 2021
eb37cb5
Merge branch 'master' into sockets/udp-UseTasks
antonfirsov Feb 2, 2021
0743b73
WIP: Harmonize SendTo validation tests
antonfirsov Feb 2, 2021
6e78c33
delete duplicate tests from ArgumentValidationTests.cs
antonfirsov Feb 2, 2021
ae70cbc
delete some unused code
antonfirsov Feb 2, 2021
a692597
delete more unused stuff
antonfirsov Feb 2, 2021
4760413
Revert "cherry pick testfix"
antonfirsov Feb 2, 2021
dacfd6d
undo adding unused SocketTestHelper property
antonfirsov Feb 2, 2021
e138a71
do not validate remoteEP argument name
antonfirsov Feb 2, 2021
96bc809
exceptions should be thrown on synchronous path
antonfirsov Feb 2, 2021
4804b52
NotBound_Throws_InvalidOperationException does not fail on Unix
antonfirsov Feb 2, 2021
adb7332
rename 'task' to 't' for consistency
antonfirsov Feb 4, 2021
8dbeabc
add comment about updating 'remoteEP' in Begin methods
antonfirsov Feb 4, 2021
fa54293
consistent Memory<T> slicing
antonfirsov Feb 4, 2021
b3e035e
workaround #47905 in tests
antonfirsov Feb 8, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix;$(NetCoreAppCurrent)</TargetFrameworks>
Expand Down Expand Up @@ -46,8 +46,6 @@
<Compile Include="System\Net\Sockets\AcceptOverlappedAsyncResult.cs" />
<Compile Include="System\Net\Sockets\BaseOverlappedAsyncResult.cs" />
<Compile Include="System\Net\Sockets\DisconnectOverlappedAsyncResult.cs" />
<Compile Include="System\Net\Sockets\OverlappedAsyncResult.cs" />
<Compile Include="System\Net\Sockets\ReceiveMessageOverlappedAsyncResult.cs" />
<Compile Include="System\Net\Sockets\UnixDomainSocketEndPoint.cs" />
<!-- Logging -->
<Compile Include="$(CommonPath)System\Net\Logging\NetEventSource.Common.cs"
Expand Down Expand Up @@ -94,9 +92,7 @@
<!-- Windows: CoreCLR -->
<Compile Include="System\Net\Sockets\AcceptOverlappedAsyncResult.Windows.cs" />
<Compile Include="System\Net\Sockets\BaseOverlappedAsyncResult.Windows.cs" />
<Compile Include="System\Net\Sockets\OverlappedAsyncResult.Windows.cs" />
<Compile Include="System\Net\Sockets\DynamicWinsockMethods.cs" />
<Compile Include="System\Net\Sockets\ReceiveMessageOverlappedAsyncResult.Windows.cs" />
<Compile Include="System\Net\Sockets\SafeSocketHandle.Windows.cs" />
<Compile Include="System\Net\Sockets\Socket.Windows.cs" />
<Compile Include="System\Net\Sockets\SocketAsyncEventArgs.Windows.cs" />
Expand Down Expand Up @@ -192,8 +188,6 @@
<Compile Include="System\Net\Sockets\AcceptOverlappedAsyncResult.Unix.cs" />
<Compile Include="System\Net\Sockets\BaseOverlappedAsyncResult.Unix.cs" />
<Compile Include="System\Net\Sockets\DisconnectOverlappedAsyncResult.Unix.cs" />
<Compile Include="System\Net\Sockets\OverlappedAsyncResult.Unix.cs" />
<Compile Include="System\Net\Sockets\ReceiveMessageOverlappedAsyncResult.Unix.cs" />
<Compile Include="System\Net\Sockets\SafeSocketHandle.Unix.cs" />
<Compile Include="System\Net\Sockets\Socket.Unix.cs" />
<Compile Include="System\Net\Sockets\SocketAsyncContext.Unix.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,5 @@ internal partial class BaseOverlappedAsyncResult : ContextAwareResult
_numBytes = numBytes;
return s_resultObjectSentinel; // return sentinel rather than boxing numBytes
}

// Used instead of the base InternalWaitForCompletion when storing an Int32 result
internal int InternalWaitForCompletionInt32Result()
{
base.InternalWaitForCompletion();
return _numBytes;
}
}
}

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading