Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the osx arm64 build. #47891

Closed
wants to merge 1 commit into from
Closed

Fix the osx arm64 build. #47891

wants to merge 1 commit into from

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Feb 5, 2021

No description provided.

@directhex
Copy link
Member

I'm seeing

/Users/directhex/Projects/runtime/src/mono/mono/utils/mono-context.c
  /Users/directhex/Projects/runtime/src/mono/mono/utils/mono-context.c:560:2: error: implicit declaration of function 'UCONTEXT_REG_SET_SP' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          UCONTEXT_REG_SET_SP (sigctx, mctx->regs [ARMREG_SP]);
          ^
  1 error generated.

Does your change also need a definition for UCONTEXT_REG_SET_SP, as well as UCONTEXT_REG_SET_PC?

@directhex
Copy link
Member

Do we have to wait on (broken) CI here? Can we even validate this in CI?

@CoffeeFlux
Copy link
Contributor

In theory the install script issue should be fixed now, so restarting the lanes.

@steveisok
Copy link
Member

I incorporated it into #47864 and yes, it works. Presumably we could close this PR.

@vargaz vargaz closed this Feb 5, 2021
@vargaz vargaz deleted the fix-arm64 branch February 5, 2021 21:45
@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants