Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup System.Reflection.Emit code. #47945

Merged
merged 3 commits into from
Feb 6, 2021
Merged

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Feb 6, 2021

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@vargaz vargaz added the area-VM-reflection-mono Reflection issues specific to MonoVM label Feb 6, 2021
@ghost
Copy link

ghost commented Feb 6, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: vargaz
Assignees: -
Labels:

area-System.Reflection-mono

Milestone: -

src/mono/mono/metadata/sre.c Outdated Show resolved Hide resolved
@vargaz
Copy link
Contributor Author

vargaz commented Feb 6, 2021

Most of the code in sre-encode.c is probably not needed, the rest of the code uses pseudo tokens so there is no need to actually encode the data.

@vargaz vargaz merged commit 7a3e1f6 into dotnet:master Feb 6, 2021
@vargaz vargaz deleted the sre-cleanup branch February 6, 2021 15:49
@ghost ghost locked as resolved and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-reflection-mono Reflection issues specific to MonoVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants