-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Remove more multi-domain functionality #48023
Conversation
Tagging subscribers to this area: @CoffeeFlux Issue DetailsStill an issue in method to ir that I need to figure out, so draft.
|
Note that whenever the current domain is set is used to detect whenever a thread is attached to the runtime or not in a couple of places, so the 'current_domain' TLS var and its set/get cannot be currently removed. |
I agree with Zoltan, I don't think we should get rid of the domain TLS var yet. I think we'll end up living with It would be nice eventually to whittle down the number of TLS vars that mean "this thread is attached in some way" (ie, MonoThreadInfo, jit_tls, and current domain) but I think that can be done separately from the current cleanup that just removes passing a domain around as an argument. |
Agreed, though actually renaming it right now seems painful.
I don't really like the thread attach/detach code, so I'll split the actual TLS simplification off into a separate PR but don't want to abandon the effort since I think simplifying that would be valuable. I think this PR can still remove most of the actual domain check/set calls that use the TLS variable. |
The test failures are relevant. |
Made a PR with a more piece-by-piece approach in |
Closing in favor of #48291 |
Still an issue in method to ir that I need to figure out, so draft.