Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package baseline for System.Drawing.Common #48074

Closed
wants to merge 1 commit into from
Closed

Update package baseline for System.Drawing.Common #48074

wants to merge 1 commit into from

Conversation

elinor-fung
Copy link
Member

PRs (e.g. #48037, #48064) failing with:

src\libraries\pkg\test\testPackages.proj(214,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Validation Failed: System.Drawing.Common is harvesting assets from package version 5.0.0 which is not the latest for that package release. Latest package version from that release is 5.0.1. In order to fix this, run `dotnet msbuild System.Drawing.Common.pkgproj /t:UpdateHarvestVersionOnPackageIndex /p:UpdateStablePackageInfo=true`

@ghost
Copy link

ghost commented Feb 9, 2021

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

PRs (e.g. #48037, #48064) failing with:

src\libraries\pkg\test\testPackages.proj(214,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Validation Failed: System.Drawing.Common is harvesting assets from package version 5.0.0 which is not the latest for that package release. Latest package version from that release is 5.0.1. In order to fix this, run `dotnet msbuild System.Drawing.Common.pkgproj /t:UpdateHarvestVersionOnPackageIndex /p:UpdateStablePackageInfo=true`
Author: elinor-fung
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

safern
safern approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@safern
Copy link
Member

safern commented Feb 9, 2021

We can merge once the Libraries All Configurations leg is past the Build step. No need to wait for the package tests to finish.

@safern safern mentioned this pull request Feb 9, 2021
Merged
@GrabYourPitchforks GrabYourPitchforks mentioned this pull request Feb 9, 2021
Merged
@safern
Copy link
Member

safern commented Feb 9, 2021

It seems like @Anipik's change is complete. #48075

@safern safern closed this Feb 9, 2021
@elinor-fung elinor-fung deleted the pkgBaseline branch February 17, 2021 01:13
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elinor-fung @safern