Removing 2 rooted types related to EventSource FeatureSwitch #48104
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| <!-- Accessed via private reflection by an external tracing controller. --> | ||
| <type fullname="System.Diagnostics.Tracing.EventPipe*" /> | ||
| <!-- The private Event methods are accessed by private reflection in the base EventSource class. --> | ||
| <type fullname="System.Diagnostics.Tracing.NativeRuntimeEventSource" /> |
There was a problem hiding this comment.
I think I understand why we can unroot the EventPipe types (see discussion).
But why can we unroot NativeRuntimeEventSource?
There was a problem hiding this comment.
@LakshanF For unrooting NativeRuntimeEventSource, can you either wait until my other PR related to NativeRuntimeEventSource is merged, or just remove the EventPipe type for now? We need to do some more testing around this. As you can see the Checked CI leg is failing because EventListeners are no longer getting the events.
| <!-- Accessed via private reflection by an external tracing controller. --> | ||
| <type fullname="System.Diagnostics.Tracing.EventPipe*" /> | ||
| <!-- The private Event methods are accessed by private reflection in the base EventSource class. --> | ||
| <type fullname="System.Diagnostics.Tracing.NativeRuntimeEventSource" /> |
There was a problem hiding this comment.
Just tested this on a test branch with my changes and I think unrooting this will require more work for us... Could you change this to only unroot the EventPipe type for now?
ghost
locked as resolved and limited conversation to collaborators
The types, EventPipe and NativeRuntimeEventSource, should no longer need to be rooted.
Goes towards fixing #43657