Allow the icu native code to be linked out when invariant globalization is enabled. #48120
Conversation
tarekgh
added
the
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer Issue Detailsnull
|
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
Outdated
Show resolved
Hide resolved
vargaz
force-pushed
the
wasm-invariant
branch
from
e4ff043
to
c2c1a80
Compare
vargaz
force-pushed
the
wasm-invariant
branch
from
25ea1c3
to
c9adf43
Compare
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
| @@ -41,6 +41,9 @@ | |||
| <ILLinkSubstitutionsXmls Include="$(ILLinkSharedDirectory)ILLink.Substitutions.NoX86Intrinsics.xml" Condition="'$(SupportsX86Intrinsics)' != 'true'" /> | |||
| <ILLinkLinkAttributesXmls Include="$(ILLinkSharedDirectory)ILLink.LinkAttributes.Shared.xml" /> | |||
| </ItemGroup> | |||
| <PropertyGroup> | |||
| <ILLinkTrimXmlLibraryBuild>$(ILLinkSharedDirectory)ILLinkTrim_LibraryBuild.xml</ILLinkTrimXmlLibraryBuild> | |||
There was a problem hiding this comment.
Is there some reason we aren't changing the eng/illink tasks to use ILLink/ILLink.Descriptors.LibraryBuild.xml for this sort of thing by default? Does it make sense to generalize the ILLink patterns for runtime?
There was a problem hiding this comment.
It's already generalized but SPC is special because it has shared part
…y preserved for the tests which need it.
vargaz
force-pushed
the
wasm-invariant
branch
from
e625cf4
to
c0e949b
Compare
|
@steveisok could you ensure this scenario is covered in functional tests |
ghost
locked as resolved and limited conversation to collaborators
Fixes #43689