Use live dependencies for netcoreapp3.0 depencies #48176
Conversation
ViktorHofer
requested review from
eiriktsarpalis,
jozkee,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @safern, @ViktorHofer Issue DetailsFixes #45560 I looked at the all the OOBs and these two stood out. I will go over the list yet again for master after this is in.
|
|
/backport to release/5.0 |
ViktorHofer
requested review from
Anipik
and removed request for
eiriktsarpalis,
layomia,
jozkee and
steveharter
There was a problem hiding this comment.
We need to add the packaging changes here. https://github.com/dotnet/runtime/blob/release/5.0/docs/project/library-servicing.md
|
@ViktorHofer is there any validation we could add in the future to avoid this from happening again? |
|
The PR is now ready. I scanned all packages twice and am now confident that I found all packages that misbehaved. While scanning them I found more issues and filed:
Yes, I believe that making sure that live dependencies (if available) are used instead of prebuilts via a common syntax is the right mitigation. That is tracked via #48238. |
* Use live dependencies for netcoreapp3.0 deps
* Use live dependencies for netcoreapp3.0 depencies (#48176) * Use live dependencies for netcoreapp3.0 deps * Disable package validation for two packages * Add baselines for touched packages * Build packages on allconfigurations leg only * Fix inbox version of System.Text.Encodings.Web Co-authored-by: Eric StJohn <ericstj@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Fixes #45560
I looked at the all the OOBs and these two stood out. I will go over the list yet again for master after this is in.