skip SslStream_ClientCertificate_SendsChain test if chain is not valid #48261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue Detailsturn assert to skip for now. I will keep looking into it but this should prevent CI failures. This is not really the test but pre-condition for successful execution. contributes to #48091
|
stephentoub
reviewed
Feb 13, 2021
| @@ -371,7 +371,10 @@ public async Task SslStream_ClientCertificate_SendsChain() | |||
| chain.ChainPolicy.DisableCertificateDownloads = false; | |||
| bool chainStatus = chain.Build(clientCertificate); | |||
| // Verify we can construct full chain | |||
| Assert.True(chain.ChainElements.Count >= clientChain.Count, "chain cannot be built"); | |||
| if (chain.ChainElements.Count < clientChain.Count) | |||
There was a problem hiding this comment.
You said "for now" in the description. Is there an issue this should be tracked against?
There was a problem hiding this comment.
This will leave #48091 open so that should be used for tracking.
stephentoub
approved these changes
Feb 13, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turn assert to skip for now. I will keep looking into it but this should prevent CI failures. This is not really the test but pre-condition for successful execution.
contributes to #48091