Make symbolsPath similar to default symbols path

[Anipik]

This is part of ongoing effort to move things towards dotnet pack.
Currently we put the symbols into a special folder packageOutputPath/symbols, but nuget pack doesnt provide any hook to change the symbols path so we are moving the symbols similar to the default behavior

[ghost]

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This is part of ongoing effort to move things towards dotnet pack.
Currently we put the symbols into a special folder packageOutputPath/symbols, but nuget pack doesnt provide any hook to change the symbols path so we are moving the symbols similar to the default behavior

Author:	Anipik
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[ViktorHofer]

Curious, what's the ideal that we should aim for, i.e. snupkg? What is the default value of where symbol packages are currently stored? Don't know much about this which is why I'm asking these questions :)

[Anipik]

What is the default value of where symbol packages are currently stored? Don't know much about this which is why I'm asking these questions :)

so dotnet pack when passed IncludeSymbols produces the nupkg and symbols.nupkg at the same path in output folder i.e. bin directory.
You can change the path to both of them but not separate one from another.
Historically, in the repo we have put the symbols in a child folder
eg packagesFolder
- symbols -> A.symbols.nupkg
- A.nupkg

after this change it will be
eg packagesFolder
-> A.nupkg
-> A.symbols.nupkg

Curious, what's the ideal that we should aim for, i.e. snupkg?

yes i think that we have separate issue for tracking that work. However, the paths will be the same for snupkg and symbols.nupkg

[safern]

after this change it will be
eg packagesFolder
-> A.nupkg
-> A.symbols.nupkg

That should be fine, that is how it is in other repos if I remember correctly. We should just make sure that if we don't add the underlying symbols folder, that we exclude those from package testing, and from publishing the nupkgs.

Curious, what's the ideal that we should aim for, i.e. snupkg?

I don't remember why we haven't used snupkg but here is a tracking issue in arcade to support this: dotnet/arcade#1959

[Anipik]

That should be fine, that is how it is in other repos if I remember correctly. We should just make sure that if we don't add the underlying symbols folder, that we exclude those from package testing, and from publishing the nupkgs.

verified, these projects are already getting excluded from the package testing as there are no corresponding package reports for these packages.

[ViktorHofer]

Approving assuming that you validated that official builds pick the symbol packages up and publish them correctly.

[Anipik]

Approving assuming that you validated that official builds pick the symbol packages up and publish them correctly.

builds are picking up the symbols and are publishing them using darc https://dev.azure.com/dnceng/internal/_build/results?buildId=1001388&view=results