-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installer build on Alpine #48505
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
cc @ViktorHofer, now we have two OS lists instead of three.. it is gradually getting improved. 🙂 |
@@ -2,7 +2,7 @@ | |||
|
|||
<PropertyGroup> | |||
<_targetFrameworkVersionIndex>$(TargetFramework.IndexOfAny(".-0123456789"))</_targetFrameworkVersionIndex> | |||
<_targetFrameworkIdentifier Condition="'$(_runtimeOSVersionIndex)' != '-1'">$(TargetFramework.SubString(0, $(_targetFrameworkVersionIndex)))</_targetFrameworkIdentifier> | |||
<_targetFrameworkIdentifier Condition="'$(_targetFrameworkVersionIndex)' != '-1'">$(TargetFramework.SubString(0, $(_targetFrameworkVersionIndex)))</_targetFrameworkIdentifier> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a 4 years old typo, which seems to be working by accident.
Great to see, thanks so much. What's the remaining OS duplication? |
Could you please verify that with this change VS still builds as expected? Just to double that check that we don't regress. |
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Currently the matrix has the following concepts (I might have missed something): OSes:
RIDs:
If we could reduce the number of properties, in the spirit of avoiding multiple ways of doing the same thing, it would make it make it more scalable and easier to comprehend. In particular,
TL;DR, ideally we just want to know two simple things: host and target .. but that is most likely an oversimplification.. 🤣 One issue is the lack of Tizen and non-portable / source-build CI legs, which results in a lots of 'what if someone is using it' kind of cautions and hence the tech debt. |
I followed these steps https://github.com/dotnet/runtime/blob/d4d50db6768f729857b27ced3b68067bf30d18de/docs/workflow/building/libraries/README.md#quick-start and built System.Text.RegularExpressions and System.Globalization solutions inside Visual Studio, all projects succeeded. |
Maybe we should move that discussion into a separate issues and loop more folks in? |
Based on the recent infra changes let's retrigger a build and then merge :) |
/azp run runtime |
/azp run runtime-dev-innerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit c9fe433.
When building for linux-musl on Alpine Linux host, the current approach is to pass
/p:OutputRid=linux-musl-{arch}
argument to./build.sh
command forsfxproj
s in installer, which useMicrosoft.DotNet.SharedFramework.Sdk
and resolveRuntimeIdentifer
aslinux-x64
, rather thanlinux-musl-x64
.PR fixes it by deleting the third OS list (
_outputRID
). Few issues highlighted after this simplification are also fixed; missing/p:CrossBuild
in src/tests restore projects.