Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LINQ APIs for Index and Range (#28776) #48559

Merged
merged 41 commits into from
Feb 22, 2021
Merged

Add LINQ APIs for Index and Range (#28776) #48559

merged 41 commits into from
Feb 22, 2021

Conversation

Dixin
Copy link
Contributor

@Dixin Dixin commented Feb 20, 2021

Add LINQ APIs for index and range:

  • Enumerable
    • ElementAt(Index)
    • ElementAtOrDefault(Index)
    • Take(Range)
  • Queryable
    • ElementAt(Index)
    • ElementAtOrDefault(Index)
    • Take(Range)

Close #28776.

This is to replace PR #47950. I initially opened PR #47950, but accidentally closed it, and I cannot reopen it.

@stephentoub @eiriktsarpalis Please review this PR. Sorry for the inconvenience.

Dixin added 30 commits January 26, 2021 23:46
@Dixin
Implement dotnet#28776: Implement LINQ APIs for index and range.
4f846fe
@Dixin
Implement dotnet#28776: Implement LINQ APIs for index and range.
0825e9a
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
ae75de2
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
2fa8291
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
58ba22c
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
4a0698c
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
6317a99
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
62570c9
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
ee298f7
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
9be2f22
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
1cdf0b8
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
a11a3db
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
4711c9a
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
3d66411
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
fdabe87
@Dixin
Merge branch 'master' of https://github.com/dotnet/runtime into linq-…
83c903c 
…index-range
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
683a2ed
@Dixin
Merge branch 'master' of https://github.com/dotnet/runtime into linq-…
28aadde 
…index-range
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
ee4dff1
@Dixin
Merge branch 'master' of https://github.com/dotnet/runtime into linq-…
fb5d551 
…index-range
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Code review up…
e9922bf 
…date.
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Code review up…
52b8617 
…date.
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
60dff47
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Code review up…
3d839c5 
…date.
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
cb7553d
@Dixin
Merge branch 'master' of https://github.com/dotnet/runtime into linq-…
8a69aeb 
…index-range
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
e17dbd9
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
fe61d59
@Dixin
Merge branch 'master' of https://github.com/dotnet/runtime into linq-…
adf6121 
…index-range
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
2ca8ca6
Dixin added 11 commits February 15, 2021 16:23
@Dixin
Implement dotnet#28776: LINQ APIs for index and range.
6374006
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Update Element…
36e1f95 
…At, keep the original behavior.
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Update Element…
0db2ce3 
…At, keep the original behavior.
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Update Element…
1ef4569 
…At, keep the original behavior.
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Add unit tests…
4f98512 
… for ElementAt, ElementAtOrDefault.
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Update unit te…
8727728 
…sts.
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Update unit te…
9a241b1 
…sts.
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Update unit te…
a6180dd 
…sts.
@Dixin
Merge branch 'master' of https://github.com/dotnet/runtime into linq-…
417617a 
…index-range.
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Update for merge.
5d8279a
@Dixin
Implement dotnet#28776: LINQ APIs for index and range. Update unit te…
88d55cd 
…sts.
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Feb 20, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Add LINQ APIs for index and range:

  • Enumerable
    • ElementAt(Index)
    • ElementAtOrDefault(Index)
    • Take(Range)
  • Queryable
    • ElementAt(Index)
    • ElementAtOrDefault(Index)
    • Take(Range)

Close #28776.

This is to replace PR #47950. I initially opened PR #47950, but accidentally closed it, and I cannot reopen it.

@stephentoub @eiriktsarpalis Please review this PR. Sorry for the inconvenience.

Author: Dixin
Assignees: -
Labels:

area-System.Linq, new-api-needs-documentation
Milestone: -

@Dixin Dixin mentioned this pull request Feb 20, 2021
Closed
eiriktsarpalis
eiriktsarpalis approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@eiriktsarpalis
Copy link
Member

CI failures seem unrelated, merging away.

@eiriktsarpalis eiriktsarpalis merged commit c63f06c into dotnet:master Feb 22, 2021
@Dixin Dixin mentioned this pull request Feb 22, 2021
Closed
@Dixin
Copy link
Contributor Author

Dixin commented Feb 22, 2021

@eiriktsarpalis @stephentoub Thank you for all the help. As we discussed, I opened a new proposal for optimization #48631. I am already working on the coding, will send PR once it is done.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees
No one assigned
Labels
area-System.Linq new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal (& implementation): LINQ APIs to enable C# 8.0 index and range for IEnumerable<T>
3 participants
@Dixin @eiriktsarpalis @stephentoub