Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileStream rewrite part II #48813

Merged
merged 31 commits into from
Mar 17, 2021

Commits on Feb 25, 2021

  1. Configuration menu
    Copy the full SHA
    cd1698d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad5b455 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Configuration menu
    Copy the full SHA
    a5ff09c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a64215 View commit details
    Browse the repository at this point in the history
  3. only DerivedFileStreamStrategy needs to have a reference to FileStream

    remove finalizer from FileStream, keep it only in DerivedFileStreamStrategy and LegacyFileStreamStrategy
    adamsitnik committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    e27ce6c View commit details
    Browse the repository at this point in the history
  4. implement ReadByte and WriteByte to make new windows strategies fully…

    … functional
    
    they can now be used directly without any buffering on top of them!
    adamsitnik committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    3f84bd5 View commit details
    Browse the repository at this point in the history
  5. implement FlushAsync for no buffering strategies as nop to get Flush_…

    …NothingToFlush_CompletesSynchronously passing
    adamsitnik committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    402cf65 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9a30387 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Configuration menu
    Copy the full SHA
    f34cb02 View commit details
    Browse the repository at this point in the history
  2. fix the Mono build

    adamsitnik committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    fb5b611 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Configuration menu
    Copy the full SHA
    b1decbf View commit details
    Browse the repository at this point in the history
  2. restore old file name to make it easier to review the code (as diff w…

    …ithin the file, not a removal and addition)
    adamsitnik committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    8d58437 View commit details
    Browse the repository at this point in the history
  3. Don't set the buffer to null, to avoid a NullReferenceException

    when users have a race condition in their code (i.e. they call
    Close when calling another method on Stream like Read).
    adamsitnik committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    33e6b8e View commit details
    Browse the repository at this point in the history
  4. fix the browser build?

    adamsitnik committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    77b6d97 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    33c7c83 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Configuration menu
    Copy the full SHA
    60cd6e7 View commit details
    Browse the repository at this point in the history
  2. simplify the source code by removing some of the optimizations that a…

    …re not providing too much gains
    adamsitnik committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    e8d6f77 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Apply suggestions from code review

    Co-authored-by: David Cantú <dacantu@microsoft.com>
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    3 people authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    7913ebf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f6b541 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    75569e3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9a4c15a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    19bb524 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dd8c4b9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    737c73c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4a5497a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Configuration menu
    Copy the full SHA
    f01948d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c152b7 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/main' into newWindowsFileStrea…

    …mStrategy
    
    # Conflicts:
    #	src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.cs
    adamsitnik committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    d52293b View commit details
    Browse the repository at this point in the history
  4. set _writePos = 0 in explicit way in Dispose so WriteByte hot path …

    …can rely on simple check
    adamsitnik committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    e54edc5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Configuration menu
    Copy the full SHA
    0294191 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c73558a View commit details
    Browse the repository at this point in the history