Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add main branch to yml files #48821

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Add main branch to yml files #48821

merged 1 commit into from
Mar 1, 2021

Conversation

ViktorHofer
Copy link
Member

Part of March's batched infrastructure rollout: #48168

@ViktorHofer ViktorHofer added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-Infrastructure labels Feb 26, 2021
@ViktorHofer ViktorHofer requested a review from a team February 26, 2021 15:38
@ViktorHofer ViktorHofer self-assigned this Feb 26, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of March's batched infrastructure rollout: #48168

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

* NO MERGE *, area-Infrastructure
Milestone: -

@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Feb 26, 2021
safern
safern reviewed Feb 26, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the best way to instead add the -main trigger, check that in, and after the rename just remove the master trigger?

@ViktorHofer
Copy link
Member Author

How would that be better?

@safern
Copy link
Member

safern commented Feb 26, 2021 •
edited
Loading

I don't know how you think of doing it but we could end on a state where people once we rename the branch and all PRs are re-targeted that the trigger is not there and then we would need to go and trigger the builds on all PRs. I don't know if that's true and you are following the guidelines, just trying to avoid a weird state 🙂

safern
safern approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in case you rather do it in one PR to unblock merging this.

@ViktorHofer ViktorHofer changed the title Rename master branch to main in yml files Add main branch to yml files Mar 1, 2021
@ViktorHofer ViktorHofer merged commit 79ae74f into dotnet:master Mar 1, 2021
@ViktorHofer ViktorHofer deleted the infra/M2M-yml branch March 1, 2021 08:55
@ViktorHofer ViktorHofer restored the infra/M2M-yml branch March 1, 2021 10:02
@ViktorHofer ViktorHofer mentioned this pull request Mar 1, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorHofer @safern