Keep tracking the file offset in memory, don't perform expensive Seek calls on every Read|WriteAsync #49145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked because it contains #48813 which needs to be reviewed and merged first.
Until then if someone is interested in looking at the changes you can see the three following commits:
d06f175
91423fa
a7ca4cb
But you should most probably just ignore it until then.
Depending on the file and buffer size,
ReadAsync
is 10-30% faster:And depending on file and buffer size
WriteAsync
is 0 to 70% faster:There is no perf penalty for sync reads and writes:
fixes #16354
fixes #25905