Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug dump template after runfo update to include dumps #49183

Merged
merged 3 commits into from
Mar 6, 2021

Conversation

safern
Copy link
Member

@safern safern commented Mar 5, 2021

No description provided.

@ghost
Copy link

ghost commented Mar 5, 2021

Tagging subscribers to this area: @safern, @ViktorHofer, @Anipik
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: safern
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have the script fix <path-to-dump> and <path-to-dmp> so they are the actual path to the dump now? The ideal is I can just copy paste the commands

@safern
Copy link
Member Author

safern commented Mar 5, 2021

The reason why I didn't do that was because there could be multiple dumps produced in a test run. However I could try emitting a command per dump I find when writing the md file or just grab the first dump and use that as the dump name to calculate the path?

@danmoseley
Copy link
Member

One command for each dump sounds good? Anything we can do to make it possible to just copy paste and get debugging. Even for someone who never contributed to the repo before.

@safern
Copy link
Member Author

safern commented Mar 5, 2021

@danmoseley I added a dump command per dump found on the helix machine. Here is an example of how it would look like if there are multiple dumps: https://gist.github.com/safern/393de39fd8b759441a769d4ae0274e0a

Let me know if you like that of if you have more suggestions to make it an easier/better experience.

@danmoseley
Copy link
Member

Looking good. Maybe worth you doing a quick test that it also works for the "core" naming pattern not just ".dmp"

I guess we don't know which are managed dumps -- native dumps won't do anything useful if you pass them to dotnet dump analyze. That seems like a problem we don't need to solve today.

@danmoseley
Copy link
Member

danmoseley commented Mar 5, 2021

Open WinDbg and open the dump with File>Open Dump.

Perhaps here we can have the template be something like

Open WinDbg, and open one of the dumps listed below with File>Open Dump.
<win-path-to-dump>

We can't give the path to Windbg - I guess most folks will open it from the start menu - but we can list the dumps there so they don't have to look down the page.

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this

@danmoseley
Copy link
Member

I'm looking forward to trying this out!!

@safern
Copy link
Member Author

safern commented Mar 6, 2021

Open WinDbg, and open one of the dumps listed below with File>Open Dump.

Good idea. Added that.

There are more things that I'd like to do, like, having sections that are Linux specific with some marker and nuking those out when the script is running on a Windows workitem for example, the commands that point to lldb.

Looking good. Maybe worth you doing a quick test that it also works for the "core" naming pattern not just ".dmp"

Done, everything seems working just fine.

@danmoseley danmoseley merged commit 11cd272 into dotnet:main Mar 6, 2021
@safern safern deleted the UpdateDebugDumpTemplate branch March 6, 2021 05:34
@ViktorHofer ViktorHofer added the enhancement Product code improvement that does NOT require public API changes/additions label Mar 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 22, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants