-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update debug dump template after runfo update to include dumps #49183
Conversation
Tagging subscribers to this area: @safern, @ViktorHofer, @Anipik Issue Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have the script fix <path-to-dump>
and <path-to-dmp>
so they are the actual path to the dump now? The ideal is I can just copy paste the commands
The reason why I didn't do that was because there could be multiple dumps produced in a test run. However I could try emitting a command per dump I find when writing the md file or just grab the first dump and use that as the dump name to calculate the path? |
One command for each dump sounds good? Anything we can do to make it possible to just copy paste and get debugging. Even for someone who never contributed to the repo before. |
@danmoseley I added a dump command per dump found on the helix machine. Here is an example of how it would look like if there are multiple dumps: https://gist.github.com/safern/393de39fd8b759441a769d4ae0274e0a Let me know if you like that of if you have more suggestions to make it an easier/better experience. |
Looking good. Maybe worth you doing a quick test that it also works for the "core" naming pattern not just ".dmp" I guess we don't know which are managed dumps -- native dumps won't do anything useful if you pass them to dotnet dump analyze. That seems like a problem we don't need to solve today. |
Perhaps here we can have the template be something like
We can't give the path to Windbg - I guess most folks will open it from the start menu - but we can list the dumps there so they don't have to look down the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for doing this
I'm looking forward to trying this out!! |
Good idea. Added that. There are more things that I'd like to do, like, having sections that are Linux specific with some marker and nuking those out when the script is running on a Windows workitem for example, the commands that point to
Done, everything seems working just fine. |
No description provided.