-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce iossimulator
RIDs, and convert as needed
#49305
Merged
Merged
Changes from 46 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
b81dd56
WIP
directhex 6f12cf7
WIP
directhex 580aeb6
WIP
directhex 54d56d7
WIP
directhex 9e7ed10
CI
directhex e5cd1ed
Merge remote-tracking branch 'origin/main' into ios-simulator-jamboree
directhex fa79b54
Valid names may only contain alphanumeric characters and '_'
directhex 8ea5d5f
Try again
directhex 57cc541
Use subgroup in offset job name generation
directhex 1611c15
Lean more into subgroups
directhex 560045e
Create ios/tvos sim offsets in non-sim lane
directhex 2459d01
Deal with OS component in RID containing a dash
directhex 65035fb
Typo
directhex 8c75eb9
subgroups in global-build-job
directhex c837923
Don't override in generate-offsets
directhex 61882bf
Fix MSBuild property syntax
directhex e341abf
Fix AOT RIDs for ios-sim and tvos-sim
directhex 659c7d7
Run iOS simulator x64 in staging
directhex 99c74c1
Fix up building/running tests on ios-sim
directhex 2df3d91
Apply exclusions correctly to sims
directhex 71c03a1
Merge remote-tracking branch 'origin/main' into ios-simulator-jamboree
directhex 1d03484
Bump ICU to build w/ renamed RIDs
directhex bf03e8e
In IOS test, deal with "ios" vs "ios-sim"
directhex a82f0ae
Merge branch 'ios-simulator-jamboree' of github.com:directhex/runtime…
directhex 1b215a3
Merge remote-tracking branch 'origin/main' into ios-simulator-jamboree
directhex 6588cfe
Detect "device or not" based on RID name
directhex 3405316
Merge branch 'ios-simulator-jamboree' of github.com:directhex/runtime…
directhex a173015
Various ios vs ios-sim fixes
directhex ff2beba
Merge remote-tracking branch 'origin/main' into ios-simulator-jamboree
directhex 1989605
Fix bad half-reverted changey
directhex 528743f
Enable passing OS subgroups & overriding targetOS based on them to Helix
directhex d1b1f78
Indent varaibles
directhex 5e4a69e
yaml!!
directhex 30f6541
Override the OS in msbuild, apparently it's easier than yaml
directhex cf90702
Revert "Override the OS in msbuild, apparently it's easier than yaml"
directhex 9775969
Try doing ios-sim conditional via env var
directhex f0ea01d
Fix
directhex f845ff2
Merge remote-tracking branch 'origin/main' into ios-simulator-jamboree
directhex 51c3d04
Update src/libraries/Native/build-native.sh
directhex 5060c65
Update src/mono/sample/iOS/Program.csproj
directhex 44d2c06
Try using osGroup=ios-sim instead of osGroup=iOS, osSubGroup=_sim
directhex 85ecc3f
Address PR review
directhex cceac84
Revert "Try using osGroup=ios-sim instead of osGroup=iOS, osSubGroup=…
directhex fd69889
Merge remote-tracking branch 'origin/main' into ios-simulator-jamboree
directhex f1a4851
Add ios-sim/tvos-sim to osGroups.json
directhex 0443e3a
Revert "Add ios-sim/tvos-sim to osGroups.json"
directhex a65d642
Merge remote-tracking branch 'origin/main' into ios-simulator-jamboree
directhex c6f007d
Rename iOS-sim to iOSSimulator
directhex a8d42ed
Fix typo
directhex 0eae82d
UpdateRuntimeFiles
directhex 57668a9
Add iOSSimulator to xplat-setup
directhex 7fb2dd2
Bump ICU
directhex 07de08f
Add simulators to osGroups
directhex 9c302e0
Fix case sensitivity error
directhex 3e9b7f8
Fix a few casing issues
directhex 6bcf466
Parent iossimulator to ios not unix. Fixes issues in known framework …
directhex 613f971
Merge remote-tracking branch 'origin/main' into ios-simulator-jamboree
directhex 85577a1
Fix bad Helix changes?
directhex 7c9a4d1
Merge remote-tracking branch 'origin/main' into ios-simulator-jamboree
directhex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use
osGroup
foriOS-sim
andtvOS-sim
rather than using thisosSubGroup
for consistency.