Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of CBOR documentation #49506

Merged
merged 4 commits into from
Apr 19, 2021
Merged

Backport of CBOR documentation #49506

merged 4 commits into from
Apr 19, 2021

Conversation

eiriktsarpalis
Copy link
Member

Fix #48985.

@eiriktsarpalis eiriktsarpalis added documentation Documentation bug or enhancement, does not impact product or test code area-System.Formats.Cbor labels Mar 11, 2021
@eiriktsarpalis eiriktsarpalis added this to the 6.0.0 milestone Mar 11, 2021
@ghost
Copy link

ghost commented Mar 11, 2021

Tagging subscribers to this area: @eiriktsarpalis, @bartonjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #48985.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Formats.Cbor, documentation
Milestone: 6.0.0

@runfoapp runfoapp bot mentioned this pull request Mar 22, 2021
Closed
@ghost ghost closed this Apr 11, 2021
@ghost
Copy link

ghost commented Apr 11, 2021

Draft Pull Request was automatically closed for inactivity. It can be manually reopened in the next 30 days if the work resumes.

@eiriktsarpalis eiriktsarpalis marked this pull request as ready for review April 19, 2021 15:55
@eiriktsarpalis
Copy link
Member Author

This should now be ready for review.

carlossanlop
carlossanlop approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from two remark suggestions.

eiriktsarpalis and others added 2 commits April 19, 2021 18:45
@eiriktsarpalis @carlossanlop
Update src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/Read…
d16162d 
…er/CborReader.Map.cs

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
@eiriktsarpalis @carlossanlop
Update src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/Writ…
1d3fa8a 
…er/CborWriter.Map.cs

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
@eiriktsarpalis eiriktsarpalis merged commit 2aba0c5 into dotnet:main Apr 19, 2021
@eiriktsarpalis eiriktsarpalis deleted the backport-cbor-docs branch April 19, 2021 17:46
@carlossanlop carlossanlop mentioned this pull request Apr 19, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@layomia layomia Awaiting requested review from layomia

@jeffhandley jeffhandley Awaiting requested review from jeffhandley

Assignees
No one assigned
Labels
area-System.Formats.Cbor documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

System.Formats.Cbor: Backport MS Docs documentation to triple slash
2 participants
@eiriktsarpalis @carlossanlop