-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] improve wasm aot symbolification when stripping isn't enabled #49526
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAdd symbols to the unstriped aot output. WIP
|
I'm not sure the MonoAOTCompiler changes are actually needed, I just started there. |
@@ -255,6 +256,7 @@ | |||
<PropertyGroup> | |||
<EmccFlags>$(_DefaultEmccFlags) $(EmccFlags)</EmccFlags> | |||
<EmccFlags>$(EmccFlags) -s DISABLE_EXCEPTION_CATCHING=0</EmccFlags> | |||
<EmccFlags Condition="'$(WasmNativeStrip)' == 'false'">$(EmccFlags) -g</EmccFlags> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a $(WasmNativeDebugSymbols)
property that adds the -g
. Maybe we should set that to true with the condition here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets do that when me move the options around, I'd like the symbols in asap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been converting the -g
to -g4
for WASM. I've been doing this since it seems that Emscripten requires -g4
in order to generated source maps. See https://emscripten.org/docs/tools_reference/emcc.html.
b568c54
to
64c664e
Compare
This change only touches the mono AOT compiler which is not involved in either of the failing lanes: __default / Libraries Test Run release mono Linux arm64 Debug / Libraries Test Run release mono Linux arm64 Debug / Send to Helix |
Add symbols to the unstriped aot output.