Big-endian fix for JsonClassInfo.GetKey #49708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uweigand
requested review from
eiriktsarpalis,
jozkee,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue Details
|
stephentoub
reviewed
Mar 16, 2021
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonClassInfo.Cache.cs
Show resolved
Hide resolved
* Skip assertion in JsonClassInfo.GetKey on big-endian (code will not ensure the properties tested here)
stephentoub
reviewed
Mar 17, 2021
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonClassInfo.Cache.cs
Outdated
Show resolved
Hide resolved
…ion/JsonClassInfo.Cache.cs
|
Thanks for the typo fix! I had fixed that locally and then forgotten to update the commit :-( |
|
Would you prefer me to quash the two commits into a single one, or should I leave it as is? |
As-is is fine. We squash when merging. |
stephentoub
approved these changes
Mar 17, 2021
|
Thanks. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(extract initial up to 7 bytes of the property name)