-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AsyncMethodBuilderOverride and PoolingAsyncValueTaskMethodBuilders #50116
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: Issue DetailsNote that this removes from the existing builders the experiment we shipped in .NET 5 that lets you opt the process into pooling all async ValueTask methods via an environment variable. Code will opt back in to the pooling on a case-by-case basis using these types, once the C# 10 compiler's support for overrides is in place.
|
...m.Private.CoreLib/src/System/Runtime/CompilerServices/PoolingAsyncValueTaskMethodBuilderT.cs
Show resolved
Hide resolved
cc: @benaadams |
@adamsitnik @carlossanlop @jozkee I guess this is your domain now? Mind reviewing when you get a chance? Thanks. |
Looking forward it it 😁 |
@benaadams, anything your keen eyes think should be done differently here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot cleaner than before; looking forward to the possibilities
ac151db
to
e335954
Compare
...libraries/System.Threading.Tasks.Extensions/tests/PoolingAsyncValueTaskMethodBuilderTests.cs
Show resolved
Hide resolved
e335954
to
e293528
Compare
e293528
to
0cecd56
Compare
Fixes #49903
Closes #13633
cc: @jcouv
Note that this removes from the existing builders the experiment we shipped in .NET 5 that lets you opt the process into pooling all async ValueTask methods via an environment variable. Code will opt back in to the pooling on a case-by-case basis using these types, once the C# 10 compiler's support for overrides is in place.