Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the iOS, Android, and macCatalyst supported platforms #50143

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Include the iOS, Android, and macCatalyst supported platforms #50143

merged 1 commit into from
Mar 24, 2021

Conversation

jeffhandley
Copy link
Member

With dotnet/sdk#16489, we are removing iOS, Android, and macCatalyst from the default set of supported platforms that will be checked by the Platform Compatibility Analyzer. We intend to reintroduce those platforms into a default set with scoping to cover libraries; that will be handled by dotnet/sdk#16488. To ensure no gap in coverage of these platforms in dotnet/runtime though, this change explicitly adds those platforms back into our own build. These platforms are added in unconditionally as they were in the SDK default so that we maintain full continuity of that coverage.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Mar 24, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

With dotnet/sdk#16489, we are removing iOS, Android, and macCatalyst from the default set of supported platforms that will be checked by the Platform Compatibility Analyzer. We intend to reintroduce those platforms into a default set with scoping to cover libraries; that will be handled by dotnet/sdk#16488. To ensure no gap in coverage of these platforms in dotnet/runtime though, this change explicitly adds those platforms back into our own build. These platforms are added in unconditionally as they were in the SDK default so that we maintain full continuity of that coverage.

Author: jeffhandley
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@jeffhandley jeffhandley added this to the 6.0.0 milestone Mar 24, 2021
@@ -35,7 +35,14 @@
<PropertyGroup Condition="'$(TargetsAnyOS)' == 'true' and !$(TargetFrameworks.Contains('$(TargetFramework)-Browser'))">
<CrossPlatformAndHasNoBrowserTarget>true</CrossPlatformAndHasNoBrowserTarget>
</PropertyGroup>


<!-- Enables warnings for Android, iOS, and macCatalyst for all builds -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be unified with the logic bellow and disable them for tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered that, but thus far we've been OK having these platforms enabled for tests. I didn't want to loosen up any more than necessary, as that could add risk of dotnet/sdk#16488 introducing new warnings.

@jeffhandley jeffhandley merged commit 8e187d1 into dotnet:main Mar 24, 2021
@jeffhandley jeffhandley deleted the include-supported-platforms branch March 24, 2021 22:16
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants