-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from mono/linker #50232
[main] Update dependencies from mono/linker #50232
Conversation
Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.2.21172.2 -> To Version 6.0.100-preview.2.21174.1
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.2.21172.2 -> To Version 6.0.100-preview.2.21176.1
Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.2.21172.2 -> To Version 6.0.100-preview.2.21177.1
@@ -651,5 +648,9 @@ | |||
<method name="ApplyUpdateSdb" /> | |||
</type> | |||
|
|||
<type fullname="System.ValueType"> | |||
<!-- https://github.com/dotnet/runtime/issues/47909 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this issue is attached to this entry. The issue says
Remove DynamicDependency from ValueType in browser builds
But this entry is unconditionally preserving the constructor on ValueType
, which are two different things in my mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove it from the xml if you want. It's only a reminder to remove it once we land final solution for System.Runtime.InteropServices.JavaScript.Runtime
dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why we need ValueType.ctor()
in the xml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have some tiny sample which managed to not require ValueType hence dropping the required dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to remove this comment, since it isn't relevant to what is being done here in the xml. I can do that in a follow up PR, so we can merge this to unblock the integration.
This pull request updates the following dependencies
From https://github.com/mono/linker