Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview3] [mbr] Fix encmap boundary and method RVA lookup. #50254

Merged

Commits on Mar 25, 2021

  1. [mbr] Fix encmap boundary and method RVA lookup.

    Two separate issues:
    
    1. When we process the EnC map, any tables after the last one that has an
    update gets an "enc_recs" pointer that's one past the last row of the
    table.  (the enc_recs pointer is used to speed up relative address lookup).  So
    at lookup time if enc_recs says to look past the end of the EnC map table, we
    know there won't be any updates - return -1.
    
    2. When looking for the updated RVA of a method, we need to go through every
    delta and find the latest one that has an update for the given method.  The
    problem is that if a later generation doesn't have an update, we would take the
    NULL return value at face value and it would look like the method had no
    updates to its body - we would go back to using the original version from
    before any updates were applied.  Instead now ignore lookup table misses and
    remember the last successful lookup.  Fixes
    dotnet#50190
    lambdageek committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    e6107b2 View commit details
    Browse the repository at this point in the history