-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for field layout verification across version bubble boundary #50364
Merged
Commits on Apr 5, 2021
-
Fix for field layout verification across version bubble boundary
When verifying field offset consistency, we shouldn't be checking base class size when the base class doesn't belong to the current version bubble. I have fixed this by adding a special case for the existing fixup encoding indicated by base class size being zero; please let me know if you find it preferable to create a new fixup type for this purpose instead. I have also created a simple regression test that was previously failing when run against the framework compiled with CG2 assembly by assembly. Thanks Tomas
Configuration menu - View commit details
-
Copy full SHA for d7cc48c - Browse repository at this point
Copy the full SHA d7cc48cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff09d66 - Browse repository at this point
Copy the full SHA ff09d66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66d4608 - Browse repository at this point
Copy the full SHA 66d4608View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1334047 - Browse repository at this point
Copy the full SHA 1334047View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0de1c2 - Browse repository at this point
Copy the full SHA a0de1c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95fe35f - Browse repository at this point
Copy the full SHA 95fe35fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 970283b - Browse repository at this point
Copy the full SHA 970283bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a180e11 - Browse repository at this point
Copy the full SHA a180e11View commit details -
Configuration menu - View commit details
-
Copy full SHA for d196751 - Browse repository at this point
Copy the full SHA d196751View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdb4b0c - Browse repository at this point
Copy the full SHA cdb4b0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for db2146e - Browse repository at this point
Copy the full SHA db2146eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c9bbd4 - Browse repository at this point
Copy the full SHA 2c9bbd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8db3511 - Browse repository at this point
Copy the full SHA 8db3511View commit details -
Configuration menu - View commit details
-
Copy full SHA for 943cd4d - Browse repository at this point
Copy the full SHA 943cd4dView commit details
Commits on Apr 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bf43f05 - Browse repository at this point
Copy the full SHA bf43f05View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.