Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Comparer_get_Default runtime test #50602

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Simplify Comparer_get_Default runtime test #50602

merged 1 commit into from
Apr 2, 2021

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Apr 1, 2021

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 1, 2021
BruceForstall
BruceForstall approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume you hand-tested it under COMPlus_GCStress=3.

@BruceForstall BruceForstall mentioned this pull request Apr 1, 2021
Closed
@EgorBo
Copy link
Member Author

EgorBo commented Apr 1, 2021

@BruceForstall yes, it takes ~25 seconds on my slow machine to finish with GCStress=0x3

@BruceForstall BruceForstall merged commit 37c8b1f into dotnet:main Apr 2, 2021
@SingleAccretion SingleAccretion mentioned this pull request Apr 6, 2021
Merged
@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Comparer_get_Default test is too slow under GCStress=3
3 participants
@EgorBo @BruceForstall @JulieLeeMSFT