-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Broken Links in Documentation #50653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could not find the /label/ folder in the repository, so I linked a GitHub guide for automatically merging pull requests
I think that callcounter.h/callcounter.cpp was renamed to callcounting.h/callcounting.cpp as I could not find "callcounter" anymore.
Changed /mono/netcore to just /mono/ as netcore is no longer a folder
/src/ folder no longer exists in ILVerification
/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun is where NativeArray.cs and NativeHashtable.cs is located
Added period to end of sentence
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Youssef1313
reviewed
Apr 2, 2021
@@ -20,7 +20,7 @@ If during the code review process a merge conflict occurs the area owner is resp | |||
|
|||
## Merging Pull Requests | |||
|
|||
Anyone with write access can merge a pull request manually or by setting the [auto-merge](/labels/auto-merge) label when it satisfies all of the following conditions: | |||
Anyone with write access can merge a pull request manually or by setting the [auto-merge](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request) label when it satisfies all of the following conditions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Anyone with write access can merge a pull request manually or by setting the [auto-merge](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request) label when it satisfies all of the following conditions: | |
Anyone with write access can merge a pull request manually or by setting the [auto-merge](https://github.com/dotnet/runtime/labels/auto-merge) label when it satisfies all of the following conditions: |
Youssef1313
reviewed
Apr 2, 2021
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
marek-safar
approved these changes
May 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #49490 (#49490), I fixed the broken links that were still broken according to https://github.com/Youssef1313/runtime/actions/runs/643550434.