Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Broken Links in Documentation #50653

Merged
merged 13 commits into from
May 10, 2021
Merged

Fixed Broken Links in Documentation #50653

merged 13 commits into from
May 10, 2021

Conversation

miraantolovich
Copy link
Contributor

As per issue #49490 (#49490), I fixed the broken links that were still broken according to https://github.com/Youssef1313/runtime/actions/runs/643550434.

I could not find the /label/ folder in the repository, so I linked a GitHub guide for automatically merging pull requests
I think that callcounter.h/callcounter.cpp was renamed to callcounting.h/callcounting.cpp as I could not find "callcounter" anymore.
Changed /mono/netcore to just /mono/ as netcore is no longer a folder
/src/ folder no longer exists in ILVerification
/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun is where NativeArray.cs and NativeHashtable.cs is located
Added period to end of sentence
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dnfadmin
Copy link

dnfadmin commented Apr 2, 2021

CLA assistant check
All CLA requirements met.

@@ -20,7 +20,7 @@ If during the code review process a merge conflict occurs the area owner is resp

## Merging Pull Requests

Anyone with write access can merge a pull request manually or by setting the [auto-merge](/labels/auto-merge) label when it satisfies all of the following conditions:
Anyone with write access can merge a pull request manually or by setting the [auto-merge](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request) label when it satisfies all of the following conditions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Anyone with write access can merge a pull request manually or by setting the [auto-merge](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request) label when it satisfies all of the following conditions:
Anyone with write access can merge a pull request manually or by setting the [auto-merge](https://github.com/dotnet/runtime/labels/auto-merge) label when it satisfies all of the following conditions:

Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@marek-safar marek-safar merged commit e39196f into dotnet:main May 10, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants