add StreamConformanceTest for HTTP CONNECT stream #50699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue Details@stephentoub @dotnet/ncl
|
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
reviewed
Apr 4, 2021
| Assert.True(pair.Stream2.CanRead); | ||
| return pair; | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this testing a different stream than Http1UpgradeResponseStreamConformanceTests is testing?
There was a problem hiding this comment.
It's the same stream, but a different way of constructing it.
There was a problem hiding this comment.
From a "we know the implementation" perspective, this doesn't seem like it's actually testing anything further:
else if (ReferenceEquals(normalizedMethod, HttpMethod.Connect) && response.StatusCode == HttpStatusCode.OK)
{
responseStream = new RawConnectionStream(this);
_connectionClose = true;
}
else if (response.StatusCode == HttpStatusCode.SwitchingProtocols)
{
responseStream = new RawConnectionStream(this);
}but if you really think it's worth adding additional stream tests for, ok.
There was a problem hiding this comment.
Yeah, I think you're right here. I'll just close this.
stephentoub
approved these changes
Apr 5, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stephentoub @dotnet/ncl