Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for LoggerMessage.Define with skipEnabledCheck #50773

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

gfoidl
Copy link
Member

@gfoidl gfoidl commented Apr 6, 2021

@ghost
Copy link

ghost commented Apr 6, 2021

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Cf. #50334 (comment)

/cc: @maryamariyan

Author: gfoidl
Assignees: -
Labels:

area-Extensions-Logging

Milestone: -

Copy link
Member

@maryamariyan maryamariyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gfoidl

@safern
Copy link
Member

safern commented Apr 22, 2021

Closed and re-opened to kick CI again.

@maryamariyan maryamariyan merged commit af71fcc into dotnet:main Apr 23, 2021
@gfoidl gfoidl deleted the loggermessage_tests branch April 24, 2021 09:55
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants