Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Text.Json: Add IAsyncEnumerable support #50778

Merged
merged 27 commits into from
Apr 12, 2021
Merged

System.Text.Json: Add IAsyncEnumerable support #50778

merged 27 commits into from
Apr 12, 2021

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Apr 6, 2021 •
edited
Loading

Fixes #1570.

FYI @pranavkm @ericstj

@eiriktsarpalis eiriktsarpalis added this to the 6.0.0 milestone Apr 6, 2021
@eiriktsarpalis eiriktsarpalis self-assigned this Apr 6, 2021
@eiriktsarpalis eiriktsarpalis requested a review from jozkee as a code owner April 6, 2021 11:44
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 6, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #1570.

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json
Milestone: 6.0.0

steveharter
steveharter reviewed Apr 7, 2021
View reviewed changes
src/libraries/System.Text.Json/src/System.Text.Json.csproj Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ClassType.cs Show resolved Hide resolved
...System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/JsonObjectConverter.cs Outdated Show resolved Hide resolved
...ries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.AsyncEnumerable.cs Show resolved Hide resolved
...ries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.AsyncEnumerable.cs Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStackFrame.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Show resolved Hide resolved
...ries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.AsyncEnumerable.cs Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadAsyncState.cs Outdated Show resolved Hide resolved
@eiriktsarpalis eiriktsarpalis mentioned this pull request Apr 7, 2021
Closed
layomia
layomia reviewed Apr 7, 2021
View reviewed changes
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadAsyncState.cs Outdated Show resolved Hide resolved
.../System.Text.Json/src/System/Text/Json/Serialization/AsyncEnumerableStreamingDeserializer.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Show resolved Hide resolved
...son/src/System/Text/Json/Serialization/Converters/Collection/IAsyncEnumerableOfTConverter.cs Outdated Show resolved Hide resolved
...System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/JsonObjectConverter.cs Outdated Show resolved Hide resolved
...System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/JsonObjectConverter.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadAsyncState.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadAsyncState.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated Show resolved Hide resolved
@eiriktsarpalis eiriktsarpalis added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Apr 7, 2021
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Apr 7, 2021
eiriktsarpalis and others added 17 commits April 9, 2021 16:46
@eiriktsarpalis
tweak test buffer values
3eec24c
@eiriktsarpalis @stephentoub
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
917d630 
…ion/Converters/Collection/IAsyncEnumerableOfTConverter.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@eiriktsarpalis @stephentoub
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
ebdce43 
…ion/Converters/Collection/IAsyncEnumerableOfTConverter.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@eiriktsarpalis
address feedback
ae83e8c
@eiriktsarpalis
increase delayInterval in serialization tests
102ed44
@eiriktsarpalis
address feedback
197fdce
@eiriktsarpalis
address feedback
8ee1051
@eiriktsarpalis
add test on exceptional IAsyncDisposable disposal
9a03fed
@eiriktsarpalis
address feedback
537dc54
@eiriktsarpalis @layomia
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
c5f57b4 
…ion/ReadAsyncState.cs

Co-authored-by: Layomi Akinrinade <layomia@gmail.com>
@eiriktsarpalis @layomia
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
68f71c7 
…ion/WriteStack.cs

Co-authored-by: Layomi Akinrinade <layomia@gmail.com>
@eiriktsarpalis
fix build and remove dead code
bfc0e7b
@eiriktsarpalis
address feedback
65b2ec4
@eiriktsarpalis
Revert unneeded JsonClassInfo.ElementType workaround
9ccf772
@eiriktsarpalis
remove state allocation on async deserialization methods
ac56fb3
@eiriktsarpalis
remove tooling artifacts
d893083
@eiriktsarpalis
address feedback
2a5b5f1
@eiriktsarpalis eiriktsarpalis merged commit 81d3a99 into dotnet:main Apr 12, 2021
@eiriktsarpalis eiriktsarpalis deleted the IAsync branch April 12, 2021 16:06
@marek-safar marek-safar mentioned this pull request Apr 15, 2021
Closed
@eerhardt eerhardt mentioned this pull request Apr 15, 2021
Closed
@DrewScoggins DrewScoggins mentioned this pull request Apr 20, 2021
Open
@davidfowl davidfowl mentioned this pull request Apr 29, 2021
Closed
@eiriktsarpalis eiriktsarpalis mentioned this pull request May 11, 2021
Closed
This was referenced May 12, 2021
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2021
@eiriktsarpalis eiriktsarpalis removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@layomia layomia layomia approved these changes

@stephentoub stephentoub stephentoub left review comments

@steveharter steveharter steveharter approved these changes

@jozkee jozkee Awaiting requested review from jozkee

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. new-api-needs-documentation
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Developers using JsonSerializer can asynchronously (de)serialize IAsyncEnumerable<T>
4 participants
@eiriktsarpalis @stephentoub @steveharter @layomia